Skip to content

[SYCL] Provide a mechanism to silence incorrect sub group size warning #11991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
againull merged 1 commit into from
Nov 29, 2023
Merged

[SYCL] Provide a mechanism to silence incorrect sub group size warning #11991

againull merged 1 commit into from
Nov 29, 2023

Conversation

@jchlanda
Copy link
Contributor

@jchlanda jchlanda commented Nov 23, 2023

As a follow up to #11687, this PR adds a mechanism to silence the warning using dedicated switch -Wno-incorrect-sub-group-size that is wrapped in the -Wno-attribute group.

@jchlanda jchlanda requested a review from a team as a code owner November 23, 2023 11:41
@jchlanda
Copy link
Contributor Author

jchlanda commented Nov 23, 2023

cc: @al42and @AlexeySachkov

@jchlanda
Copy link
Contributor Author

jchlanda commented Nov 23, 2023

Looks like the CI is struggling with this job:

Run actions/github-script@v6
/usr/bin/docker exec  edaf472a173900aba409d3c8ca4043c4d7b3afeb3eadbe6811193ed02d978ca3 sh -c "cat /etc/*release | grep ^ID"
TypeError: Cannot read properties of undefined (reading 'id')

https://github.com/intel/llvm/actions/runs/6969312601/job/18965004349#step:13:1

@jchlanda jchlanda force-pushed the jakub/silence_sub_group_warning branch from d3b4c3a to 9ffecd8 Compare November 24, 2023 14:14
premanandrao
premanandrao approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

smanna12
smanna12 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@smanna12 smanna12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@againull againull merged commit 338b390 into intel:sycl Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@premanandrao premanandrao premanandrao approved these changes

+1 more reviewer

@smanna12 smanna12 smanna12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jchlanda @premanandrao @smanna12 @againull