-
Notifications
You must be signed in to change notification settings - Fork 769
Add e2e test for queue::fill with a range of pattern sizes #16544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a new e2e test to validate queue::fill outputs for any pattern size between 1 and 32 bytes. Backend implementations of this feature commonly branch on the pattern size to implement an optimized path for specific values. This test ensures a wide range of cases is tested, including also odd numbers of bytes.
Move "clang-format: off" to ensure UNSUPPORTED-TRACKER follows directly after UNSUPPORTED Co-authored-by: Udit Kumar Agarwal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test LGTM. I'd seek an additional review from @maarquitos14 since he reviewed this test originally in #15991.
Hi @rafbiels,
Another example: https://github.com/intel/llvm/actions/runs/12690937422/job/35374577967. I think the failure is rather flaky. |
Test added in intel#16544 was originally flagged as UNSUPPORTED for OpenCL CPU device only, but has now been observed to fail also for other OpenCL devices. Flag the test as UNSUPPORTED for all OpenCL devices.
Test added in intel#16544 was originally flagged as UNSUPPORTED for OpenCL CPU device only, but has now been observed to fail also for other OpenCL devices. Flag the test as UNSUPPORTED for all OpenCL devices.
Thank you for flagging this @uditagarwal97! It looks like this issue may affect any OpenCL device, so I'm changing the UNSUPPORTED flag to cover them all in #16588 |
Add a new e2e test to validate queue::fill outputs for any pattern size between 1 and 32 bytes.
Backend implementations of this feature commonly branch on the pattern size to implement an optimized path for specific values. This test ensures a wide range of cases is tested, including also odd numbers of bytes.
Re-adds #15991 reverted in #16465 with changes to fix #16434.