[SYCL] the first kernel function declaration should be added with attribute #18405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fznamznon
reviewed
May 13, 2025
clang/lib/Sema/SemaSYCL.cpp
Outdated
| } | ||
| bool FirstDecl = true; | ||
| clang::SourceLocation Loc = FD->getLocation(); | ||
| while (!Redecls.empty()) { |
There was a problem hiding this comment.
AFAIK a FunctionDecl should have a member isFirstDecl. Can we just loop over FD->redecls(), and issue an error in case an attribute is applied to a decl returning false from isFirstDecl?
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fznamznon
reviewed
May 14, 2025
| @@ -12676,7 +12676,8 @@ def err_free_function_variadic_args : Error< | |||
| "free function kernel cannot be a variadic function">; | |||
| def err_free_function_return_type : Error< | |||
| "SYCL free function kernel should have return type 'void'">; | |||
|
|
|||
| def err_free_function_first_occurrence_missing_attr: Error< | |||
| "the first occurrence of kernel free function should be declared with attribute add_ir_attributes_function with 'sycl-nd-range-kernel' or 'sycl-single-task-kernel'">; | |||
There was a problem hiding this comment.
Suggested change
| "the first occurrence of kernel free function should be declared with attribute add_ir_attributes_function with 'sycl-nd-range-kernel' or 'sycl-single-task-kernel'">; | |
| "the first occurrence of SYCL kernel free function should be declared with 'sycl-nd-range-kernel' or 'sycl-single-task-kernel' compile time properties">; |
| for (const auto &NameValuePair : NameValuePairs) { | ||
| if (NameValuePair.first == "sycl-nd-range-kernel" || | ||
| NameValuePair.first == "sycl-single-task-kernel") { | ||
| clang::SourceLocation Loc = FD->getLocation(); |
There was a problem hiding this comment.
I'm pretty sure clang nns is not required here.
Suggested change
| clang::SourceLocation Loc = FD->getLocation(); | |
| SourceLocation Loc = FD->getLocation(); |
| @@ -10,6 +10,22 @@ foo(int start, ...) { // expected-error {{free function kernel cannot be a varia | |||
| foo1(int start, ...) { // expected-error {{free function kernel cannot be a variadic function}} | |||
| } | |||
|
|
|||
| // expected-note@+1 {{conflicting attribute is here}} | |||
| [[__sycl_detail__::add_ir_attributes_function("sycl-single-task-kernel", 1)]] void | |||
There was a problem hiding this comment.
Could you please extend the testing with the following cases:
- There are more than 2 redeclarations and the attribute is not on the first one
- Templated free function
- Overloads with the same name, different set of arguments and attributes applied to each should not trigger the diag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs Defining a free function kernel contains:
The property must appear on the first declaration of the function in the translation unit. Redeclarations of the function may optionally be decorated with the same property if the property argument is the same. The effect is the same regardless of whether redeclarations are so decorated.
This PR changes
isFreeFunctionto define if the first occurrence of kernel free function has attribute or not. New clang diagnostics was added to highlight that first occurrence does not have attribute but the next has.