[UR] Check for memory alignment before calling clEnqueueMemFillINTEL_fn in OpenCL #18423
+7
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… OpenCL. Use checkUSMImplAlignment from the Hip adapter for this but moved it to a common header.
|
Arc fails tracked here #18416 |
Those are not the same tests. |
|
Created an issue for them here #18463 |
aelovikov-intel
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes oneapi-src/unified-runtime#2440
clEnqueueMemFillINTEL returns CL_INVALID_VALUE if dst_ptr is NULL, or if dst_ptr is not aligned to pattern_size bytes.
This PR adds a memory alignment check before calling
clEnqueueMemFillINTELto ensure we can safely call it, otherwise take the host side copy path.Re-enables the
USM/fill_any_size.cppand also movescheckUSMImplAlignmentfrom Hip into a common header so it can be used in both Hip and OpenCL.