[SYCL][CUDA] Expand search for generated_cuda_meta.h#18436
Merged
steffenlarsen merged 3 commits intointel:syclfrom May 26, 2025
Merged
[SYCL][CUDA] Expand search for generated_cuda_meta.h#18436steffenlarsen merged 3 commits intointel:syclfrom
steffenlarsen merged 3 commits intointel:syclfrom
Conversation
On some systems `CUDA_Toolkit_ROOT` might be emtpy, even though CUDA is properly found in the CMake. This can cause a failed search for `generated_cuda_meta.h`. In that case only a warning is emitted when building `cuda_trace_collector`, but this can fail the `-Werror` build. This patch ensures that if we can find `CUPTI`, we can find this file.
ProGTX
requested review from
rafbiels and
slawekptak
and removed request for
slawekptak
rafbiels
approved these changes
May 13, 2025
Contributor
Author
|
CI failures are known: #18416 |
Contributor
Author
|
Friendly ping @intel/llvm-reviewers-runtime |
Contributor
Author
|
Another ping @intel/llvm-reviewers-runtime , this is blocking our internal CI |
steffenlarsen
approved these changes
May 26, 2025
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
LGTM!
For future reference, it might be best to not remove the auto-assigned runtime reviewer. 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some systems
CUDA_Toolkit_ROOTmight be emtpy,even though CUDA is properly found in the CMake.
This can cause a failed search for
generated_cuda_meta.h.In that case only a warning is emitted when building
cuda_trace_collector,but this can fail the
-Werrorbuild.This patch ensures that if we can find
CUPTI, we can find this file.