[UR][Graph] Strengthen in-order command-buffer property #18444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
force-pushed
the
ewan/ur_enforce_in-order
branch
from
26f0318 to
7047439
Compare
EwanC
force-pushed
the
ewan/ur_enforce_in-order
branch
from
7047439 to
31b457f
Compare
EwanC
force-pushed
the
ewan/ur_enforce_in-order
branch
2 times, most recently
from
51a9df2 to
84a11de
Compare
EwanC
force-pushed
the
ewan/ur_enforce_in-order
branch
from
84a11de to
b2c1963
Compare
Actions issue intel#18330 to enhance the semantics of the UR command-buffer in-order property such that sync-point dependencies will always be ignored.
EwanC
force-pushed
the
ewan/ur_enforce_in-order
branch
from
b2c1963 to
5209cae
Compare
Bensuo
approved these changes
May 15, 2025
pbalcer
approved these changes
May 15, 2025
|
@intel/llvm-gatekeepers This is good to merge, thanks |
This was referenced May 15, 2025
sommerlukas
pushed a commit
that referenced
this pull request
May 21, 2025
CTS test `urInOrderUSMCommandBufferExpTest.WithHints` has been reported as failing on unrelated PRs on PVC in GitHub CI #18544 which were added recently in #18444 Disable the UR CTS in-order tests on Level-Zero V1 adapter until this bug is investigated and resolved. I've disabled more than the specific test that fails, as the others UR tests inheriting from the base fixture are variants, and it is not unlikely that we'd end up seeing flaky fails in CI for them too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #18330 to enhance the semantics of the UR command-buffer in-order property such that sync-point dependencies will always be ignored.
Also fixes up an artifact in the UR command-buffer spec where it says that descriptors to the command-buffer creation API can be optional, when after #17058 they are mandatory.