[XPTI][INFRA] Fixes minor standalone build and code issues #18452
+51
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tested std::call_once against current implementation in Framework::instance() and saw no increase in performance overhead - Added cleanup for default stream "xpti.framework" Signed-off-by: Vasanth Tovinkere <[email protected]>
- Switched to EmHash for notifications and this improves performance by 10% Signed-off-by: Vasanth Tovinkere <[email protected]>
steffenlarsen
approved these changes
May 14, 2025
There was a problem hiding this comment.
LGTM, but I would like to hear @KseniyaTikhomirova's thoughts as well.
xptifw/CMakeLists.txt
Outdated
| @@ -1,6 +1,6 @@ | |||
| cmake_minimum_required(VERSION 3.20.0) | |||
| cmake_minimum_required(VERSION 3.5) | |||
There was a problem hiding this comment.
why is it 3.5? is it intentional change?
There was a problem hiding this comment.
I was testing with CMake 4.0 and that was the minimum requirement - reverted back to 3.20.0
Signed-off-by: Vasanth Tovinkere <[email protected]>
KseniyaTikhomirova
approved these changes
May 14, 2025
|
Failure is unrelated with an open issue already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is first of many XPTI changes to address the performance issues that have been reported.
(1) xpti::Framework::instance() - testing the use of std::call_once against current implementation
(2) Added cleanup for default stream "xpti.framework"
(3) Switched to EmHash instead of std::unordered_map that improve notification performance by 10%
Most of the performance overheads are from xptiRegisterObject() and xptiAddMetadata(). This requires changes in the SYCL runtime an will be addressed in a subsequent PR