[SYCL][UR][L0 v2] Implement API logging using L0 loader#18475
Merged
sarnex merged 2 commits intointel:syclfrom May 15, 2025
Merged
[SYCL][UR][L0 v2] Implement API logging using L0 loader#18475sarnex merged 2 commits intointel:syclfrom
sarnex merged 2 commits intointel:syclfrom
Conversation
igchor
force-pushed
the
reapply_api_logging
branch
from
e13f37b to
80da905
Compare
maarquitos14
approved these changes
May 14, 2025
Contributor
maarquitos14
left a comment
maarquitos14
left a comment
There was a problem hiding this comment.
Just a typo, otherwise LGTM.
igchor
force-pushed
the
reapply_api_logging
branch
from
80da905 to
07ceecf
Compare
maarquitos14
approved these changes
May 15, 2025
igchor
force-pushed
the
reapply_api_logging
branch
from
07ceecf to
a675319
Compare
The adapter sets certain env variables during adapter init. Preloding it will set those variables and result in unexpected behavior for the legacy adater.
Contributor
|
CI is passing and this fixes CI so merging now, please get a review from and address any feedback from the UR L0 team in a followup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reapplies some of the changes from #17536 (without changes to leak_checker which broke internal testing).
This fixes: #18463