Skip to content

[NFC][SYCL] Update memory_manager to pass context_impl by raw pointers #18966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented Jun 12, 2025

Part of the ongoing refactoring to prefer raw ptr/ref for SYCL RT objects by default with explicit shared_from_this when lifetimes need to be extended.

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you please add the motivation for these changes to the description?

@aelovikov-intel aelovikov-intel merged commit bbbd081 into intel:sycl Jun 13, 2025
24 of 25 checks passed
@aelovikov-intel aelovikov-intel deleted the context_impl-mem_mngr branch June 13, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants