Skip to content

[SYCL][UR] Add UR_QUEUE_INFO_EMPTY support for OpenCL #19151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 3, 2025
Merged

[SYCL][UR] Add UR_QUEUE_INFO_EMPTY support for OpenCL #19151

merged 6 commits into from
Jul 3, 2025
+16 −12

Conversation

HPS-1
Copy link
Contributor

@HPS-1 HPS-1 commented Jun 25, 2025 •
edited
Loading

To fix CTS test (https://github.com/KhronosGroup/SYCL-CTS/blob/b5cf985ecc497f82045165e9309fdc7a990c7e60/tests/extension/khr_queue_empty_query/queue_empty.cpp) failures for the sycl_khr_queue_empty_query extension (implemented in #18799), which are caused by the error UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION emitted in the old code.

HPS-1 added 2 commits June 25, 2025 10:47
@HPS-1
[SYCL][UR] Add UR_QUEUE_INFO_EMPTY support for OpenCL
c544c8d 
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
@HPS-1
[SYCL][UR] Fix comment
4757a1f 
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
@HPS-1 HPS-1 temporarily deployed to WindowsCILock June 25, 2025 17:51 — with GitHub Actions Inactive
@HPS-1 HPS-1 temporarily deployed to WindowsCILock June 25, 2025 18:59 — with GitHub Actions Inactive
@HPS-1 HPS-1 temporarily deployed to WindowsCILock June 25, 2025 18:59 — with GitHub Actions Inactive
@HPS-1 HPS-1 mentioned this pull request Jun 26, 2025
Closed
@HPS-1
[SYCL][UR] Fix E2E tests to stop looking for OpenCl exception
08d2c68 
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
@HPS-1 HPS-1 temporarily deployed to WindowsCILock June 30, 2025 01:17 — with GitHub Actions Inactive
@HPS-1 HPS-1 temporarily deployed to WindowsCILock June 30, 2025 02:38 — with GitHub Actions Inactive
@HPS-1 HPS-1 temporarily deployed to WindowsCILock June 30, 2025 03:29 — with GitHub Actions Inactive
@HPS-1 HPS-1 temporarily deployed to WindowsCILock June 30, 2025 04:52 — with GitHub Actions Inactive
@HPS-1 HPS-1 marked this pull request as ready for review June 30, 2025 09:32
@HPS-1 HPS-1 requested review from a team as code owners June 30, 2025 09:32
@HPS-1 HPS-1 requested a review from slawekptak June 30, 2025 09:32
igchor
igchor reviewed Jun 30, 2025
View reviewed changes
aarongreig
aarongreig reviewed Jul 2, 2025
View reviewed changes
@HPS-1 HPS-1 temporarily deployed to WindowsCILock July 3, 2025 10:24 — with GitHub Actions Inactive
@HPS-1 HPS-1 temporarily deployed to WindowsCILock July 3, 2025 11:01 — with GitHub Actions Inactive
@HPS-1 HPS-1 temporarily deployed to WindowsCILock July 3, 2025 11:01 — with GitHub Actions Inactive
@HPS-1
Copy link
Contributor Author

HPS-1 commented Jul 3, 2025

@intel/llvm-reviewers-runtime Need an approval to merge this. Thanks in advance!

@HPS-1
Copy link
Contributor Author

HPS-1 commented Jul 3, 2025

@intel/llvm-gatekeepers Please merge this, thanks!

@uditagarwal97
Copy link
Contributor

@intel/llvm-gatekeepers Please merge this, thanks!

This commit will be authored by 65581261+HPS-1@users.noreply.github.com.

Please change your email privacy settings in Github profile, so that commits are authored by your intel/codeplay email.

@HPS-1
Copy link
Contributor Author

HPS-1 commented Jul 3, 2025

@intel/llvm-gatekeepers Please merge this, thanks!

This commit will be authored by 65581261+HPS-1@users.noreply.github.com.

Please change your email privacy settings in Github profile, so that commits are authored by your intel/codeplay email.

Changed the setting. Can you try again?

@uditagarwal97
Copy link
Contributor

Interestingly, the workflow to check for use of private emails incorrectly passes: https://github.com/intel/llvm/actions/runs/16047943939/job/45283619261?pr=19151
Smells like some bug (being tracked in #17675).

@uditagarwal97 uditagarwal97 merged commit bcc45f4 into intel:sycl Jul 3, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uditagarwal97 uditagarwal97

@aarongreig aarongreig

@igchor igchor

@slawekptak slawekptak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HPS-1 @uditagarwal97 @aarongreig @igchor