Skip to content

[SYCL] Add support for eliminated arg masks in SYCLBIN kernel bundles #19163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 2, 2025
Merged

[SYCL] Add support for eliminated arg masks in SYCLBIN kernel bundles #19163

merged 8 commits into from
Jul 2, 2025

Conversation

steffenlarsen
Copy link
Contributor

This commit fixes an issue where kernel bundles created from SYCLBIN would not correctly filter based on the DAE-produced kernel arg masks.

@steffenlarsen
[SYCL] Add support for eliminated arg masks in SYCLBIN kernel bundles
09cda1e 
This commit fixes an issue where kernel bundles created from SYCLBIN
would not correctly filter based on the DAE-produced kernel arg masks.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen requested a review from a team as a code owner June 26, 2025 05:49
aelovikov-intel
aelovikov-intel approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert in that area of the codebase, so extra reviewer might be beneficial.

@steffenlarsen
Fix merge mistake
dee759b 
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
jopperm
jopperm approved these changes Jun 30, 2025
View reviewed changes
@steffenlarsen
Merge remote-tracking branch 'intel/sycl' into steffe/syclbin_elim_ar…
31b0d36 
…g_mask
@steffenlarsen
Fix header
bd680c0 
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen
Remove req after fix
f5bc838 
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen
Add xfail
be35a07 
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen
Copy link
Contributor Author

Windows failure:
Failed Tests (3):
SYCL :: Adapters/level_zero/ext_intel_cslice.cpp
SYCL :: Adapters/level_zero/ext_intel_queue_index.cpp
SYCL :: Adapters/sycl-ls-uuid-subdevs.cpp

#18576

@steffenlarsen steffenlarsen merged commit 4b96a99 into intel:sycl Jul 2, 2025
36 of 39 checks passed
@steffenlarsen steffenlarsen deleted the steffe/syclbin_elim_arg_mask branch July 2, 2025 05:22
@uditagarwal97 uditagarwal97 mentioned this pull request Jul 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jopperm jopperm

@dm-vodopyanov dm-vodopyanov

@aelovikov-intel aelovikov-intel

@sommerlukas sommerlukas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steffenlarsen @jopperm @dm-vodopyanov @aelovikov-intel