[SYCL][Doc] Fix work_group_scratch_memory example#20506
Merged
steffenlarsen merged 2 commits intointel:syclfrom Nov 19, 2025
Merged
[SYCL][Doc] Fix work_group_scratch_memory example#20506steffenlarsen merged 2 commits intointel:syclfrom
steffenlarsen merged 2 commits intointel:syclfrom
Conversation
The example in the specification was using an old API that we removed in intel#14785. Update the example and the spec wording to use `launch_config` from sycl_ext_oneapi_enqueue_functions to pass the property with the size of the scratch memory.
gujinghui
reviewed
Oct 31, 2025
sycl/doc/extensions/experimental/sycl_ext_oneapi_work_group_scratch_memory.asciidoc
Show resolved
Hide resolved
These `constexpr` declarations aren't necessary, and they make the example more confusing. The purpose of this extension is to allocate a runtime-defined amount of local memory, so the memory size shouldn't be declared `constexpr`.
gujinghui
approved these changes
Nov 18, 2025
steffenlarsen
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example in the specification was using an old API that we removed in #14785. Update the example and the spec wording to use
launch_configfrom sycl_ext_oneapi_enqueue_functions to pass the property with the size of the scratch memory.