-
Notifications
You must be signed in to change notification settings - Fork 794
[SYCL][NewOffloadModel] Update SYCL device library generation for new offloading model #20512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
YixingZhang007
wants to merge
7
commits into
intel:sycl
Choose a base branch
from
YixingZhang007:offload_cant_find_bundle_issue
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[SYCL][NewOffloadModel] Update SYCL device library generation for new offloading model #20512
YixingZhang007
wants to merge
7
commits into
intel:sycl
from
YixingZhang007:offload_cant_find_bundle_issue
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The modifications to set the new offloading model as default in this PR were directly copied from (#15121). These changes will be removed once CI confirms there are no regressions. |
8257fbd to
76e101f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the SYCL device library build and end-to-end tests to support the new offloading model, while maintaining backward compatibility for the old offloading model, with the following key changes.
libsycl-itt-compiler-wrappers.o) is now compiled using the new offloading model, and the library ending with.new.o(such aslibsycl-itt-compiler-wrappers.new.o) has been renamed to.old.o(such aslibsycl-itt-compiler-wrappers.old.o), representing builds with the old offloading model. These changes are made inlibdevice/cmake/modules/SYCLLibdevice.cmake.sycl/test-e2e/Config/kernel_from_file.cppandsycl/test-e2e/SeparateCompile/test.cpphave been updated. The tests now validate both the new offloading model, and the backward compatibility for the old model (usingclang-offload-bundlerto extract device code from libraries).