Skip to content

Conversation

@YixingZhang007
Copy link
Contributor

@YixingZhang007 YixingZhang007 commented Oct 30, 2025

This pull request refactors the SYCL device library build and end-to-end tests to support the new offloading model, while maintaining backward compatibility for the old offloading model, with the following key changes.

  1. The default device library (such as libsycl-itt-compiler-wrappers.o) is now compiled using the new offloading model, and the library ending with .new.o (such as libsycl-itt-compiler-wrappers.new.o) has been renamed to .old.o (such as libsycl-itt-compiler-wrappers.old.o), representing builds with the old offloading model. These changes are made in libdevice/cmake/modules/SYCLLibdevice.cmake.
  2. The end-to-end tests in sycl/test-e2e/Config/kernel_from_file.cpp and sycl/test-e2e/SeparateCompile/test.cpp have been updated. The tests now validate both the new offloading model, and the backward compatibility for the old model (using clang-offload-bundler to extract device code from libraries).

@YixingZhang007 YixingZhang007 requested review from a team as code owners October 30, 2025 04:33
@YixingZhang007 YixingZhang007 marked this pull request as draft October 30, 2025 04:33
@YixingZhang007 YixingZhang007 changed the title [SYCL][NewOffloadModel] Remove Clang Offload Bundler testing to fix E2E test failures with new offloading model [SYCL][NewOffloadModel] Remove Clang Offload Bundler testing to fix E2E test failures Oct 30, 2025
@YixingZhang007 YixingZhang007 changed the title [SYCL][NewOffloadModel] Remove Clang Offload Bundler testing to fix E2E test failures [SYCL][NewOffloadModel] Remove Clang Offload Bundler testing for new offloading model Oct 30, 2025
@YixingZhang007 YixingZhang007 changed the title [SYCL][NewOffloadModel] Remove Clang Offload Bundler testing for new offloading model [SYCL][NewOffloadModel] Update SYCLLibdevice generation for new offloading model Nov 2, 2025
@YixingZhang007 YixingZhang007 changed the title [SYCL][NewOffloadModel] Update SYCLLibdevice generation for new offloading model [SYCL][NewOffloadModel] Update SYCL device library generation for new offloading model Nov 2, 2025
@YixingZhang007
Copy link
Contributor Author

The modifications to set the new offloading model as default in this PR were directly copied from (#15121). These changes will be removed once CI confirms there are no regressions.

@YixingZhang007 YixingZhang007 marked this pull request as ready for review November 2, 2025 20:31
@YixingZhang007 YixingZhang007 marked this pull request as draft November 2, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant