[SYCL] Extend no-handler submission path to support kernel properties. #20524
+139
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
There was a problem hiding this comment.
Pull Request Overview
This PR extends the no-handler (direct) kernel submission path to support kernel properties. Previously, kernel properties required handler-based submission, but now they can be used with the more efficient direct submission path for single_task, parallel_for, and nd_launch operations.
- Added kernel property support to direct submission functions
- Updated function signatures to accept and propagate kernel properties
- Removed conditional checks that forced handler-based submission when properties were present
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sycl/test/abi/sycl_symbols_linux.dump | Updated ABI symbols to reflect new function signatures with kernel property parameters |
| sycl/source/queue.cpp | Added Props parameter to template instantiations and forwarding calls |
| sycl/source/detail/queue_impl.hpp | Updated method signatures to accept kernel property holder parameter |
| sycl/source/detail/queue_impl.cpp | Implemented property validation and extraction in the direct submission path |
| sycl/include/sycl/queue.hpp | Refactored function signatures to support properties, merged kernel and launch properties, and removed property-based submission restrictions |
| sycl/include/sycl/khr/free_function_commands.hpp | Removed property checks from conditional compilation and updated function calls |
| sycl/include/sycl/ext/oneapi/experimental/enqueue_functions.hpp | Enabled property support for nd_launch with launch_config and updated other enqueue functions |
| HasKernelPropertiesGetMethod< | ||
| const KernelType &>::value) && | ||
| !(detail::KernelLambdaHasKernelHandlerArgT<KernelType, | ||
| // TODO The handler-less path does not support kernel functions with the |
There was a problem hiding this comment.
Extra space in comment: 'does not support kernel functions' should be 'does not support kernel functions'.
Suggested change
| // TODO The handler-less path does not support kernel functions with the | |
| // TODO The handler-less path does not support kernel functions with the |
| detail::submit_kernel_direct_single_task( | ||
| q, ext::oneapi::experimental::empty_properties_t{}, | ||
| std::forward<KernelType>(k), codeLoc); | ||
| q, std::forward<KernelType>(k), |
There was a problem hiding this comment.
Extra space after 'q,': should be 'q, std::forward' with single space.
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.