[OFFLOAD][L0] Also lookup for function symbols #20771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Level Zero plugin to look up both global variables and function symbols when resolving offload variable device addresses. Previously, only global pointers were searched; now function pointers are also checked.
Key Changes:
- Modified
getOffloadVarDeviceAddrto attempt function pointer lookup after global pointer lookup fails - Added dynamic wrapper for
zeModuleGetFunctionPointerAPI - Removed unnecessary
std::stringconversion ofCNameparameter
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| offload/plugins-nextgen/level_zero/src/L0Program.cpp | Extended symbol lookup to check both global and function pointers, eliminated redundant string conversion |
| offload/plugins-nextgen/level_zero/src/L0DynWrapper.cpp | Added dynamic wrapper for zeModuleGetFunctionPointer API |
Co-authored-by: Copilot <[email protected]>
pbalcer
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.