[SYCL][L0] optimize re-use of command-lists #8870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey V Maslov <[email protected]>
jandres742
approved these changes
Mar 30, 2023
Signed-off-by: Sergey V Maslov <[email protected]>
againull
reviewed
Mar 30, 2023
| // | ||
| // TODO: rename ImmCmdListsEventCleanupThreshold to not mention | ||
| // be for "immediate" only. | ||
| if (Queue->CommandListMap.size() > ImmCmdListsEventCleanupThreshold) { |
There was a problem hiding this comment.
ImmCmdListsEventCleanupThreshold represents number of events in the command list but here you check number of command lists used in the queue. Do you think it worth having a separate threshold variable for that?
There was a problem hiding this comment.
sure, since you asked I will add a new one
Signed-off-by: Sergey V Maslov <[email protected]>
againull
approved these changes
Mar 30, 2023
|
@intel/llvm-gatekeepers: the only fail is a known flaky reported in #8847:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heuristically prune command-lists for re-use by others in the same context