Skip to content

[SYCL] Add sycl/test-e2e tests to in-tree build #8884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2023
Merged

[SYCL] Add sycl/test-e2e tests to in-tree build #8884

merged 1 commit into from
Mar 31, 2023

Conversation

aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented Mar 30, 2023 •
edited by bader
Loading

This change enables sycl/test-e2e test targets inside SYCL runtime library build workspace.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner March 30, 2023 16:22
@bader bader changed the title [SYCL] Add the ability to configure sycl/test-e2e tests inside RT build workspace [SYCL] Add sycl/test-e2e tests to in-tree build Mar 30, 2023
@aelovikov-intel aelovikov-intel temporarily deployed to aws March 30, 2023 17:40 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel temporarily deployed to aws March 30, 2023 20:06 — with GitHub Actions Inactive
@aelovikov-intel
Copy link
Contributor Author

SYCL :: AtomicRef/atomic_memory_order_acq_rel.cpp is tracked in #8847.

@aelovikov-intel
Copy link
Contributor Author

@bso-intel , @bader , ping.

bso-intel
bso-intel approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader
Copy link
Contributor

bader commented Mar 31, 2023

Failed Tests (1):
SYCL :: AtomicRef/atomic_memory_order_acq_rel.cpp

Reported in #8847.

@bader bader merged commit 0b13f0a into intel:sycl Mar 31, 2023
@sommerlukas
Copy link
Contributor

@aelovikov-intel:
Thanks for fixing this.

Can we close #8828 now that this is merged, or do you plan additional changes related to #8828?

@aelovikov-intel
Copy link
Contributor Author

Yes we can! I forgot to reference the issue in my PRs :)

@aelovikov-intel aelovikov-intel deleted the e2e-in-tree-build branch April 7, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader left review comments

@bso-intel bso-intel bso-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aelovikov-intel @bader @sommerlukas @bso-intel