[SYCL] Add marray support to rest math built-in functions #8912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds support of sycl::marray to the rest math built-in functions (SYCL 2020, Table 175), and adds missing tests for math and common functions for intel#8631 to reduce number of upcoming cherry-picks.
AlexeySachkov
approved these changes
Apr 3, 2023
|
@sergey-semenov, ping. |
dm-vodopyanov
commented
Apr 4, 2023
|
|
||
| #include <sycl/sycl.hpp> | ||
|
|
||
| #define TEST(FUNC, MARRAY_ELEM_TYPE, DIM, EXPECTED, DELTA, ...) \ |
There was a problem hiding this comment.
Do we have to use a macro here? Seems like we can get away with a function template, which would be preferrable. The same goes for the other test file.
There was a problem hiding this comment.
I would suggest to implement this in a separate PR for all marray builtin tests, including these.
Debugging test failures
sergey-semenov
approved these changes
Apr 6, 2023
|
All failures are unrelated: Failed Tests (3): Jenkins/Precommit (created internal ticket) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support of sycl::marray to the rest of math built-in functions (SYCL 2020, Table 175), and adds missing tests for math and common functions for #8631 to reduce number of upcoming cherry-picks.