Skip to content

[SYCL-MLIR] Opaque pointer support in SYCL-to-LLVM conversion #8944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 5, 2023

Conversation

sommerlukas
Copy link
Contributor

First step to add opaque pointer support for the SYCL-MLIR project: Make the lowering patterns in the SYCL-to-LLVM lowering compatible with opaque pointers.

Emitting typed or opaque pointers is controlled by the use-opaque-pointers pass option, that was added.

Partly resolves #8616.

@sommerlukas sommerlukas added the sycl-mlir Pull requests or issues for sycl-mlir branch label Apr 4, 2023
@sommerlukas sommerlukas requested a review from victor-eds April 4, 2023 13:42
@sommerlukas sommerlukas self-assigned this Apr 4, 2023
@sommerlukas
Copy link
Contributor Author

Similar to #8767, the existing tests were copied to a file with a -typed-pointer suffix and the original test files were updated to test opaque pointers.

In contrast to #8767, I did not duplicate the patterns, but rather added logic for opaque and typed pointers where necessary.

@sommerlukas sommerlukas force-pushed the opaque-pointer-sycl-to-llvm branch from 561a574 to 7d6737d Compare April 4, 2023 16:24
Copy link
Contributor

@victor-eds victor-eds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For tests with opaque pointers, can we have the full line checked?, i.e., add the missing types after the -> !llvm.ptr in GEPOp, loaded types in LoadOp, etc.

@sommerlukas sommerlukas requested a review from victor-eds April 5, 2023 10:15
Copy link
Contributor

@victor-eds victor-eds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single NIT. LGTM if you agree or not.

Signed-off-by: Lukas Sommer <[email protected]>
@sommerlukas sommerlukas merged commit 001a03c into intel:sycl-mlir Apr 5, 2023
@sommerlukas sommerlukas deleted the opaque-pointer-sycl-to-llvm branch April 5, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sycl-mlir Pull requests or issues for sycl-mlir branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants