-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL-MLIR] Opaque pointer support in SYCL-to-LLVM conversion #8944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL-MLIR] Opaque pointer support in SYCL-to-LLVM conversion #8944
Conversation
Signed-off-by: Lukas Sommer <[email protected]>
Signed-off-by: Lukas Sommer <[email protected]>
Signed-off-by: Lukas Sommer <[email protected]>
Signed-off-by: Lukas Sommer <[email protected]>
Signed-off-by: Lukas Sommer <[email protected]>
Signed-off-by: Lukas Sommer <[email protected]>
Signed-off-by: Lukas Sommer <[email protected]>
Signed-off-by: Lukas Sommer <[email protected]>
Signed-off-by: Lukas Sommer <[email protected]>
561a574
to
7d6737d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For tests with opaque pointers, can we have the full line checked?, i.e., add the missing types after the -> !llvm.ptr
in GEPOp
, loaded types in LoadOp
, etc.
Signed-off-by: Lukas Sommer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a single NIT. LGTM if you agree or not.
Signed-off-by: Lukas Sommer <[email protected]>
First step to add opaque pointer support for the SYCL-MLIR project: Make the lowering patterns in the SYCL-to-LLVM lowering compatible with opaque pointers.
Emitting typed or opaque pointers is controlled by the
use-opaque-pointers
pass option, that was added.Partly resolves #8616.