refactor: replace if/else with classList.toggle and .toggleAttribute …#7682
Open
ykolo-glu wants to merge 1 commit intojellyfin:masterfrom
Open
refactor: replace if/else with classList.toggle and .toggleAttribute …#7682ykolo-glu wants to merge 1 commit intojellyfin:masterfrom
ykolo-glu wants to merge 1 commit intojellyfin:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codesmell Removal in onTypeChange
Changes
Replace if/else blocks with classList.toggle for hiding/showing elements
Replace setAttribute/removeAttribute with toggleAttribute for required fields
Fix typo: suppportsSubmit → supportsSubmit
Issues
Fixes cognitive complexity issue in onTypeChange (livetvtuner.js):
https://sonarcloud.io/project/issues?impactSeverities=HIGH&issueStatuses=OPEN%2CCONFIRMED&types=CODE_SMELL&id=jellyfin_jellyfin-web&open=AXepJq0ZYTlMEX6vFIKi