Skip to content

feat: support to import an image with image name#161

Draft
suzuki-shunsuke wants to merge 1 commit intomasterfrom
feat/support-to-import-image
Draft

feat: support to import an image with image name#161
suzuki-shunsuke wants to merge 1 commit intomasterfrom
feat/support-to-import-image

Conversation

@suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Mar 29, 2021

Close #156

  • change docker_image's ID from ${imageID}${imageName} to ${imageName}
  • support to import docker_image with image name

e.g.

$ terraform import docker_image.alpine alpine:3.13.0

What's appropriate docker_image's ID?

  • image ID?
  • image name?
  • image ID + image name?

I considered about it, and concluded that image name is best.

@suzuki-shunsuke suzuki-shunsuke added enhancement New feature or request r/image Relates to the image resource labels Mar 29, 2021
@github-actions
Copy link

This pull request is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 7 days.
If you don't want this pull request to be closed, please set the label pinned.

@github-actions github-actions bot added the stale label May 29, 2021
@mavogel mavogel removed the stale label May 30, 2021
@mavogel
Copy link
Contributor

mavogel commented May 30, 2021

related to #74 . Are you still on this @suzuki-shunsuke ?

@suzuki-shunsuke
Copy link
Contributor Author

Sorry but I forget the status of this issue.
Probably I kept this pull request draft due to any problem, but I can't remember it.

@github-actions
Copy link

This pull request is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 7 days.
If you don't want this pull request to be closed, please set the label pinned.

@github-actions github-actions bot added the stale label Aug 20, 2021
@mavogel mavogel added pinned and removed stale labels Aug 24, 2021
@Junkern Junkern removed this from the v3.0.0 milestone Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request pinned r/image Relates to the image resource

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change docker_image resource id to image id and support import

3 participants