feat: add new data source for docker_containers#644
Open
KetchupBomb wants to merge 2 commits intokreuzwerker:masterfrom
Open
feat: add new data source for docker_containers#644KetchupBomb wants to merge 2 commits intokreuzwerker:masterfrom
KetchupBomb wants to merge 2 commits intokreuzwerker:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #642 by adding a new data source --
docker_containers-- for listing containers.Right now, the data source has no schema beyond what is computed. The primary attribute,
containers, is currently a list of strings. This is a naive implementation that can be improved, but is still quite compatible with Terraform throughjsondecode():The Docker Engine API endpoint exposes more parameters that can be incorporated into this data source, but I wanted to put this up for initial consideration and guidance for me as a Golang noob, and first time working with Terraform Provider development.
terraform planorterraform applycommands will likely report changes to the underlying data source.make testorgo testto fail. Advice on making sure I am writing tests correctly would be appreciated.