Merged
Conversation
c5af142 to
e47bc80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates across multiple files to enhance the functionality of the Commercetools Terraform provider. The most significant changes include adding support for event subscriptions, updating dependencies in the
go.modfile, and improving the handling of subscription update actions. Below is a breakdown of the most important changes grouped by theme:Support for Event Subscriptions:
eventblock to the subscription schema, allowing users to subscribe to specific events. This includes attributes forresource_type_idandtypes, with detailed descriptions provided indocs/resources/subscription.mdandinternal/resources/subscription/resource.go. [1] [2]Eventstruct ininternal/resources/subscription/model.go, including methods to convert between native and platform event subscription formats.eventsActionin theOrderSubscriptionTypesActionsfunction. [1] [2]Dependency Updates:
go.modfile, includinggolang.org/x/text,golang.org/x/crypto, andgithub.com/labd/commercetools-go-sdk, to ensure compatibility and leverage the latest features. [1] [2]Subscription Update Logic Improvements:
OrderSubscriptionTypesActionsfunction to include event subscriptions and ensure proper ordering of actions based on non-empty attributes.internal/resources/subscription/model_test.goto cover scenarios involving event subscriptions and validate the updated logic. [1] [2]Documentation Enhancements:
docs/resources/subscription.mdandexamples/resources/commercetools_subscription/resource.tf, providing clear guidance for users. [1] [2]Minor Code Improvements:
SortOrderfield inresourceCartDiscountCreateto use a helper function for string references, improving code consistency.