Skip to content

refactor: hiro deprecated endpoints #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025
Merged

Conversation

fbwoolf
Copy link
Contributor

@fbwoolf fbwoolf commented Mar 28, 2025

@fbwoolf fbwoolf force-pushed the refactor/hiro-deprecated-apis branch from 2cb3940 to c5afce2 Compare March 31, 2025 13:51
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 3.33333% with 58 lines in your changes missing coverage. Please review.

Project coverage is 37.91%. Comparing base (23a1776) to head (5cc645a).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...query/src/stacks/balance/address-balances.query.ts 0.00% 31 Missing ⚠️
packages/query/src/stacks/stacks-client.ts 0.00% 21 Missing ⚠️
...s/web/app/queries/balance/account-balance.hooks.ts 0.00% 3 Missing ⚠️
packages/query/index.ts 0.00% 1 Missing ⚠️
packages/query/src/stacks/hiro-api-types.ts 0.00% 1 Missing ⚠️
...kages/query/src/stacks/hiro-requests-priorities.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1028      +/-   ##
==========================================
+ Coverage   37.85%   37.91%   +0.06%     
==========================================
  Files         295      294       -1     
  Lines       12258    12242      -16     
  Branches      938      937       -1     
==========================================
+ Hits         4640     4642       +2     
+ Misses       7618     7600      -18     
Files with missing lines Coverage Δ
packages/query/src/query-prefixes.ts 100.00% <100.00%> (ø)
packages/query/index.ts 0.00% <0.00%> (ø)
packages/query/src/stacks/hiro-api-types.ts 0.00% <0.00%> (ø)
...kages/query/src/stacks/hiro-requests-priorities.ts 0.00% <0.00%> (ø)
...s/web/app/queries/balance/account-balance.hooks.ts 0.00% <0.00%> (ø)
packages/query/src/stacks/stacks-client.ts 0.00% <0.00%> (ø)
...query/src/stacks/balance/address-balances.query.ts 0.00% <0.00%> (ø)
Components Coverage Δ
bitcoin 63.85% <ø> (ø)
query 11.24% <3.50%> (+0.08%) ⬆️
utils 82.36% <ø> (ø)
crypto 68.21% <ø> (ø)
stacks 82.39% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fbwoolf fbwoolf marked this pull request as ready for review April 1, 2025 15:22
@fbwoolf fbwoolf requested review from kyranjamie and alter-eggo April 1, 2025 15:22
Copy link
Contributor

@alexp3y alexp3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀 I'll follow your lead and migrate the endpoints in @leather.io/services as well.

@fbwoolf fbwoolf added this pull request to the merge queue Apr 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2025
@fbwoolf fbwoolf added this pull request to the merge queue Apr 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2025
@alter-eggo alter-eggo force-pushed the refactor/hiro-deprecated-apis branch from c5afce2 to 5cc645a Compare April 2, 2025 16:27
@fbwoolf fbwoolf added this pull request to the merge queue Apr 2, 2025
Merged via the queue into dev with commit a0d688d Apr 2, 2025
20 checks passed
@fbwoolf fbwoolf deleted the refactor/hiro-deprecated-apis branch April 2, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants