Skip to content

fix: rpc network type errors #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

fix: rpc network type errors #1307

merged 1 commit into from
May 30, 2025

Conversation

fbwoolf
Copy link
Contributor

@fbwoolf fbwoolf commented May 29, 2025

Getting type errors with the rpc networks on these three when trying to update extension packages here:
leather-io/extension#6286

Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.70%. Comparing base (9e1b9d6) to head (2ef004b).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1307   +/-   ##
=======================================
  Coverage   13.70%   13.70%           
=======================================
  Files         917      917           
  Lines       38681    38681           
  Branches     1621     1621           
=======================================
  Hits         5303     5303           
  Misses      33378    33378           
Components Coverage Δ
bitcoin 62.78% <ø> (ø)
query 11.29% <ø> (ø)
utils 81.94% <ø> (ø)
crypto 68.21% <ø> (ø)
stacks 65.07% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to keep the passthrough option, which is a little bit more permissive in the case additional args are passed, means we're less likely to introduce breaking changes

@fbwoolf fbwoolf force-pushed the fix/rpc-type-errors branch from 2861e6b to 2ef004b Compare May 30, 2025 15:16
@fbwoolf fbwoolf added this pull request to the merge queue May 30, 2025
Merged via the queue into dev with commit 42c8519 May 30, 2025
21 checks passed
@fbwoolf fbwoolf deleted the fix/rpc-type-errors branch May 30, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants