Skip to content

chore(mobile): add node_modules/.pnpm to fingerprint.ignore #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025

Conversation

pete-watters
Copy link
Contributor

This PR updates our EAS .fingerprintignore file so that it excludes node_modules/.pnpm.

@camerow and I had a call with the Expo team and they helped us pinpoint this as a reason why we keep seeing new fingerprints.

@leather-bot
Copy link
Contributor

This PR's build fingerprint differs from the latest production build's fingerprint. Merging this PR would require us to submit the build to the stores. (Note: Make sure your PR is up to date)

Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.51%. Comparing base (72d7377) to head (6a7f3ff).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1442   +/-   ##
=======================================
  Coverage   14.51%   14.51%           
=======================================
  Files         915      915           
  Lines       38432    38432           
  Branches     1675     1675           
=======================================
  Hits         5578     5578           
  Misses      32854    32854           
Components Coverage Δ
bitcoin 63.40% <ø> (ø)
query 11.32% <ø> (ø)
utils 82.39% <ø> (ø)
crypto 68.14% <ø> (ø)
stacks 65.07% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@tigranpetrossian tigranpetrossian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pete!

@edgarkhanzadian
Copy link
Collaborator

Wait wat, do we have a .pnpm folder in apps/mobile/node_modules ? Afaik it is only in the root node_modules/.pnpm

@pete-watters
Copy link
Contributor Author

I'm merging this out of hope but not convinced it will work. I'll roll back if needed, see this thread

@pete-watters pete-watters added this pull request to the merge queue Jul 11, 2025
@pete-watters
Copy link
Contributor Author

Wait wat, do we have a .pnpm folder in apps/mobile/node_modules ? Afaik it is only in the root node_modules/.pnpm

I'll give this a try and see if it works. If not I will roll back and try ../../node_modules

Merged via the queue into dev with commit d65d539 Jul 11, 2025
20 checks passed
@pete-watters pete-watters deleted the chore/EAS-fingerprint-ignore branch July 11, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants