Skip to content

Conversation

shahidact
Copy link
Contributor

This patch tries to extend the mixed precision isupport and add basic infra to define or create quantization kernel as we get more clarity on kind of primitive operations required.

Addition of run time test is not in scope of this patch.

This patch tries to extend the mixed precision isupport and
add basic infra to define or create quantization kernel as we get
more clarity on kind of primitive operations required.

Addition of run time test is not in scope of this patch.
@adam-smnk
Copy link
Contributor

General question, shouldn't we migrate to lighthouse's gen?

@rolfmorel
Copy link
Contributor

General question, shouldn't we migrate to lighthouse's gen?

That's indeed a good question. Might be a good example to dogfood how we facilitate downstream projects interacting with lighthouse.

@rengolin
Copy link
Contributor

General question, shouldn't we migrate to lighthouse's gen?

That's indeed a good question. Might be a good example to dogfood how we facilitate downstream projects interacting with lighthouse.

For now, I'd duplicate, because we don't know what we can build with this work. Once we're happy with the result, we should bring this up to the lighthouse and help talk about quantization upstream.

Copy link
Contributor

@adam-smnk adam-smnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General structure seems fine
I assume that the sequence of quant ops has been tested and is correct

@rengolin
Copy link
Contributor

rengolin commented Sep 1, 2025

I'd like to see at least two back-and-forth execution test:

  1. I8 -> F32 -> I8: Must be identical results
  2. F32 -> I8 -> F32: Should be equal to a small delta

@rengolin
Copy link
Contributor

rengolin commented Sep 1, 2025

Test failures are due to NFS migration and will be fixed in time

…untime test.

 -Adds '-print-input' flag to print input arguments for visual inspection.
 -Refactored and updated the corresponding APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants