Conversation
cnpetra
requested changes
Mar 12, 2025
thartland
approved these changes
Mar 13, 2025
Collaborator
thartland
left a comment
There was a problem hiding this comment.
I think this is a great first time and don't have any big concerns that prevent me from approving this but do have a few questions. Are the smtProblems omitted in order to reduce the amount of code in hiopbbpy? Should we change the name from hiopbbpy to hioppy? While hiopbbpy is intended for use in black box BO optimization. If we eventually make hiop algorithms available in the hiopbbpy interface then it seems that a user could just use of the hiop algorithms in any python application.
cnpetra
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a GP-based Bayesian Optimization (BO) solver into HiOp.