[SPEC2017] Use correct input/output file paths for different benchmark types #247
Conversation
…k types These programs did not take into account the relationship between the benchmark type(rate vs. speed, test vs. train) and the input/output filenames. - 503.bwaves_r - 521.wrf_r - 554.roms_r - 603.bwaves_s - 621.wrf_s - 654.roms_s
|
I just find that the fix for 603 is redundant with #200. |
|
cc @nmosier |
|
Since this contains fixes similar to those for 604 for other tests as well, I am ok with this superseding the other. This looks fine to me, but I am not familiar with the SPEC benchmarks, so it may be better to wait for someone else to approve. |
|
I just noticed that this has been up for 2 weeks already. If it's ok with you, I'd like to leave it up for a bit longer to see if someone more knowledgeable about this can take a look. Otherwise, I'll approve it. Is that ok? |
Thanks for your comments. It seems that relatively few people are starting to run spec's Fortran benchmarks via the llvm-test-suite approach. People may be testing using the runcpu approach. I'm OK to wait more time. |
|
Linaro runs/has run spec Fortran benchmarks, @luporl might be able to review. |
There was a problem hiding this comment.
This LGTM, but since I haven't touched this in months, I'd like someone else to take a second look.
@kiranchandramohan could you please take a look?
I have not used the spec2017 setup from llvm-testsuite. So I cannot immediately review this. |
These programs did not take into account the relationship between the benchmark type(rate vs. speed, test vs. train) and the input/output filenames.