[TorchToLinalg] Fix i8 scalar dtype conversion by passing dstOriginalDtype#4454
Open
snarang181 wants to merge 1 commit intollvm:mainfrom
Open
[TorchToLinalg] Fix i8 scalar dtype conversion by passing dstOriginalDtype#4454snarang181 wants to merge 1 commit intollvm:mainfrom
snarang181 wants to merge 1 commit intollvm:mainfrom
Conversation
Signed-off-by: Samarth Narang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an iree-compile failure when lowering Torch programs that require converting scalars/elements to an 8-bit integer destination (Byte/Char). convertScalarToDtype requires dstOriginalDtype for i8 because Torch distinguishes Byte (u8) vs Char (i8) while MLIR integers are often signless; without this metadata the helper emits unimplemented.
(Motivated by iree-org/iree#23136)