-
Notifications
You must be signed in to change notification settings - Fork 81
Use uv for package management
#1206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
michplunkett
wants to merge
8
commits into
develop
Choose a base branch
from
use-uv-for-install
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
363f58b
add skipped tests
michplunkett 553e689
Update CONTRIB.md
michplunkett 3f30a70
Update CONTRIB.md
michplunkett 0bb8a6b
Update Makefile
michplunkett ab07856
install reqs with uv
michplunkett 98dd48c
Update Dockerfile-test
michplunkett 55b7b99
Update Dockerfile-test
michplunkett 62caac3
Update Dockerfile-test
michplunkett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -90,7 +90,15 @@ test: start | |
|
|
||
| .PHONY: lint | ||
| lint: | ||
| pre-commit run --all-files | ||
| uv run pre-commit run --all-files | ||
|
|
||
| .PHONY: env | ||
| env: | ||
| uv venv | ||
|
|
||
| .PHONY: install | ||
| install: | ||
| uv pip install -r requirements.txt -r dev-requirements.txt | ||
|
Comment on lines
92
to
+101
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update and add |
||
|
|
||
| # Stop containers | ||
| .PHONY: stop | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,16 +4,23 @@ WORKDIR /usr/src/app | |
|
|
||
| ENV CURL_FLAGS="--proto =https --tlsv1.2 -sSf -L --max-redirs 1 -O" | ||
|
|
||
| ENV DEBIAN-FRONTEND noninteractive | ||
| ENV DEBIAN_FRONTEND=noninteractive | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed the variable name: https://askubuntu.com/q/972516 |
||
| ENV DISPLAY=:1 | ||
| ENV PYTHONDONTWRITEBYTECODE=1 | ||
|
|
||
| # install apt dependencies | ||
| RUN apt-get update && apt-get install -y xvfb libpq-dev python3-dev graphviz-dev graphviz && \ | ||
| apt-get clean | ||
|
|
||
| # Install uv | ||
| RUN curl -LsSf https://astral.sh/uv/install.sh | sh | ||
|
|
||
| # Add uv to PATH | ||
| ENV PATH="/root/.local/bin:$PATH" | ||
|
|
||
| COPY requirements.txt /usr/src/app/ | ||
| RUN pip3 install --no-cache-dir -r requirements.txt | ||
|
|
||
| RUN uv pip install --system -r requirements.txt | ||
|
|
||
| COPY create_db.py test_data.py /usr/src/app/ | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the install instructions.