Skip to content

Add prepare hook script to run patch-package #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2025
Merged

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Aug 9, 2025

For making the process for preparing development simplify, add prepare script to run patch-package for npm install / npm ci (without arguments).

patch-package recommend to run patch-package in postinstall hook, but it also triggers unnecessarily when installed Marp CLI by users, such as npm i @marp-team/marp-cli --save.

Marp CLI is currently using patch-package only for dev dependencies, so we have no need to run it in postinstall hook.

"ws": "^8.18.3",
"yargs": "^17.7.2"
},
"overrides": {
"patch-package": {
"tmp": "^0.2.5"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yhatt yhatt merged commit 5495638 into main Aug 9, 2025
16 checks passed
@yhatt yhatt deleted the prepare-patch-package branch August 9, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant