chore: enable MEN-8168 feature flag in the useradm service#492
Open
kjaskiewiczz wants to merge 1 commit intomendersoftware:stagingfrom
Open
chore: enable MEN-8168 feature flag in the useradm service#492kjaskiewiczz wants to merge 1 commit intomendersoftware:stagingfrom
kjaskiewiczz wants to merge 1 commit intomendersoftware:stagingfrom
Conversation
Signed-off-by: Krzysztof Jaskiewicz <[email protected]>
alfrunes
reviewed
Oct 21, 2025
| USERADM_REDIS_TIMEOUT_SEC: "1" | ||
| USERADM_REDIS_LIMITS_EXPIRE_SEC: "3600" | ||
| USERADM_TOTP_ISSUER: Mender | ||
| USERADM_MEN-8168: "true" |
Contributor
There was a problem hiding this comment.
Unfortunately, this change won't introduce any change on the templates itself. All the env.* values are actually hard-coded values in the pod template. You could use customEnvs value, but I don't think that's good practice.
I think this is a better candidate to put under the featureGates value as this is something we plan on making the default (remove) on the next major release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.