Skip to content

made use of store + testing packages #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

made use of store + testing packages #879

wants to merge 14 commits into from

Conversation

mzedel
Copy link
Contributor

@mzedel mzedel commented Aug 20, 2025 •
edited
Loading

No description provided.

@mzedel mzedel requested a review from a team as a code owner August 20, 2025 12:53
@mzedel mzedel marked this pull request as draft August 20, 2025 12:53
@mzedel mzedel added the WIP label Aug 20, 2025
@mzedel mzedel changed the title WIP - made use of store + testing packages made use of store + testing packages Aug 20, 2025
@mzedel mzedel force-pushed the refac/use-packages branch 2 times, most recently from 123449d to c706666 Compare August 26, 2025 09:32
@mzedel mzedel removed the WIP label Aug 26, 2025
@mzedel mzedel marked this pull request as ready for review August 26, 2025 09:36
mzedel added 14 commits August 26, 2025 13:42
@mzedel
refactor(gui): made use of store + testing package in codebase
c06eb5e 
Signed-off-by: Manuel Zedel <[email protected]>
@mzedel
refactor(gui): made use of testing package & utils in tests
219cb1c 
Signed-off-by: Manuel Zedel <[email protected]>
@mzedel
chore(gui): aligned react version w/ testing package requirement
f41ca3d 
Signed-off-by: Manuel Zedel <[email protected]>
@mzedel
chore(gui): aligned store constant access to work w/ store package
ff2e5f1 
Signed-off-by: Manuel Zedel <[email protected]>
@mzedel
refactor(gui): aligned thunk spying w/ updated store package format
8f88d98 
Signed-off-by: Manuel Zedel <[email protected]>
@mzedel
test(gui): removed reliance on cookie setting check as it happens in …
f9b29ea 
…store

Signed-off-by: Manuel Zedel <[email protected]>
@mzedel
chore(gui): improve non esm module imports to work w/ vitest
406bef4 
Signed-off-by: Manuel Zedel <[email protected]>
@mzedel
chore(gui): removed reliance on package included flag image references
6aaf92d 
- to avoid issue rendering them

Signed-off-by: Manuel Zedel <[email protected]>
@mzedel
chore(gui): added extra color fallback to work w/ sparse testing theme
e783bf5 
Signed-off-by: Manuel Zedel <[email protected]>
@mzedel
refactor(gui): let email check be done in thunk to align msw handler …
6da9fed 
…location

Signed-off-by: Manuel Zedel <[email protected]>
@mzedel
chore(gui): aligned store mock setup w/ current ui state
f10b48f 
Signed-off-by: Manuel Zedel <[email protected]>
@mzedel
test(gui): aligned PAT test naming w/ component
b2b431e 
Signed-off-by: Manuel Zedel <[email protected]>
@mzedel
test(gui): post testing/store package adjustment
0355706 
Signed-off-by: Manuel Zedel <[email protected]>
@mzedel
chore(gui): aligned snapshots
0c67ecd 
Signed-off-by: Manuel Zedel <[email protected]>
@mzedel mzedel force-pushed the refac/use-packages branch from c706666 to 0c67ecd Compare August 26, 2025 11:45
@mzedel mzedel requested a review from mineralsfree August 26, 2025 12:02
mineralsfree
mineralsfree approved these changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@mineralsfree mineralsfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mineralsfree mineralsfree mineralsfree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzedel @mineralsfree