[libffi] Support LLVM on Windows by adding quotes around the path to CCAS

[qmfrederik]

This PR fixes compiling libffi on Windows, when using the LLVM toolchain.

The path to CCAS may include spaces. On Windows, the build process runs within a MSYS2 shell, which doesn't deal withs paces in paths very well. Add quotes around the path to fix this.

This fixes building libffi with the LLVM toolchain on Windows.

• Changes comply with the maintainer guide.
• SHA512s are updated for each updated download.
• The "supports" clause reflects platforms that may be fixed by this new version.
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

[dg0yt]

I acknowledge that the PR passes CI for libffi, but...
... this overrides the CCAS setting from vcpkg_configure_make which carries "ABIFLAGS" in addition to the tool executable.

In general, autoconf packages are extremely volatile around spaces in paths. These variable values are passed from Windows CMake to Msys2 bash/configure to Msys2 bash/libtool. Quoting and escaping has to be done all the time, and it isn't always done correctly. That's why the directory of cl.exe is added to PATH instead.

I would be glad if the problems could be overcome, and maybe the vcpkg-make port is already better than the old scripts. But we really need to be sure what we need in vcpkg-make and what we need in individual ports.

[qmfrederik]

This overrides the CCAS setting from vcpkg_configure_make which carries "ABIFLAGS" in addition to the tool executable.

I don't disagree, but the same is being done in the MSVC case, right ? (line 26)

That's why the directory of cl.exe is added to PATH instead.

I assume that could be done; we could parse VCPKG_DETECTED_CMAKE_C_COMPILER, add the directory to PATH, and then use the executable name for CCAS?

[vicroms]

I assume that could be done; we could parse VCPKG_DETECTED_CMAKE_C_COMPILER, add the directory to PATH, and then use the executable name for CCAS?

@qmfrederik This seems worth a try, it avoids the spaces in paths issue that is the root of so many problems.