fix: complain when filter is used on undefined in strict and semi-strict mode#877
Merged
mitsuhiko merged 3 commits intomitsuhiko:mainfrom Mar 3, 2026
Merged
fix: complain when filter is used on undefined in strict and semi-strict mode#877mitsuhiko merged 3 commits intomitsuhiko:mainfrom
mitsuhiko merged 3 commits intomitsuhiko:mainfrom
Conversation
Recent maturin versions fail on develop when strip=true is set in pyproject.toml because develop uses debuginfo. Remove the global strip setting and pass --strip explicitly in wheel release jobs so tests and local development work with latest maturin while keeping release artifacts stripped.
Propagate state-aware argument conversion through Rest<T> and Vec<T> so undefined values inside nested string conversions no longer coerce silently under SemiStrict/Strict modes. Add regression tests for Rest<String> and Vec<String> filter arguments in strict and semi-strict undefined behavior tests.
Contributor
Author
|
Thanks! A release would be amazing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #876
AI Disclaimer: Code entirely written by Claude.