fix(virtual-modules): transitive dependency breaks PNPM #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gioboa
reviewed
Feb 12, 2026
Comment on lines
+43
to
+52
| if ( | ||
| importer === REMOTE_ENTRY_ID && | ||
| !id.startsWith('.') && | ||
| !id.startsWith('/') && | ||
| !id.startsWith('\0') && | ||
| !id.startsWith('virtual:') | ||
| ) { | ||
| const resolved = await this.resolve(id, __filename, { skipSelf: true }); | ||
| if (resolved) return resolved; | ||
| } |
Collaborator
There was a problem hiding this comment.
It looks great to me 👏 Thanks @joshuaellis
I double checked with AI and __filename is CJS-only, in ESM we can use fileURLToPath(import.meta.url)
Let's add a fallback
const importerPath = typeof __filename !== 'undefined' ? __filename : fileURLToPath(import.meta.url);
const resolved = await this.resolve(id, importerPath, { skipSelf: true });
if (resolved) return resolved;
gioboa
requested changes
Feb 12, 2026
Collaborator
gioboa
left a comment
gioboa
left a comment
There was a problem hiding this comment.
That's awesome 👍
I added a small comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using @module-federation/vite with pnpm (strict mode, no shameful hoisting), the dev server fails with:
This fix intercepts imports originating from the virtual remote entry and re-resolves them from this package's own location, where the transitive dependencies are available.
Notes
There weren't any unit tests nor e2e tests that I could write to be more confident in the change other than running on my local instance – open to suggestions though.