perf: Replace futures-locks with DashMap registry and bounded channels#1080
Open
perf: Replace futures-locks with DashMap registry and bounded channels#1080
Conversation
- Replace `futures-locks::RwLock<HashMap>` with `DashMap` for the `ClientRegistry`, eliminating async lock contention on every connect/disconnect/notify - Switch from `mpsc::unbounded` to bounded channels with configurable `client_channel_capacity` (default 50) to apply backpressure and cap per-client memory - All registry methods become synchronous, removing `.await` from callers
jrconlin
requested changes
Feb 26, 2026
…ate backpressure from disconnects
jrconlin
approved these changes
Feb 27, 2026
Member
|
By the way, I'm not convinced that this actually saves memory or is substantially faster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
futures-locks::RwLock<HashMap>withDashMapfor theClientRegistry, eliminating async lock contention on every connect/disconnect/notifympsc::unboundedto bounded channels with configurableclient_channel_capacity(default 50) to apply backpressure and cap per-client memory.awaitfrom callers