bug-2020292: Implement GitHub Actions security guidelines.#7164
Merged
bug-2020292: Implement GitHub Actions security guidelines.#7164
Conversation
fkiriakos07
reviewed
Mar 3, 2026
| base_tag="$(date +v%Y.%m.%d)" | ||
| tag="$base_tag" | ||
| gh api "repos/${{ github.repository }}/tags" --paginate \ | ||
| gh api "repos/$GITHUB_REPOSITORY/tags" --paginate \ |
Contributor
|
looks good, thanks @smarnach , I am curious why the steps were skipped, is that normal? |
Contributor
Author
The steps to actually build and push a Docker image are only run after merging the PR, or when cutting a new release. New Docker images automatically get deployed to stage. |
biancadanforth
approved these changes
Mar 13, 2026
Contributor
biancadanforth
left a comment
biancadanforth
left a comment
There was a problem hiding this comment.
Definitely a little more verbose, but I can understand the recommendation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the security assurance team's recommendations for GitHub Actions security. Most of the changes here are about avoiding the use of the
GITHUB_ENVfile to set environment variables.