dashing line collections (hlines, vlines, ...) #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasb-eyer
added a commit
to lucasb-eyer/mpld3
that referenced
this pull request
Dec 1, 2025
This goes together with mpld3/mplexporter#71 it's the mpld3 side of the change. Again, done together with gpt-5.1-codex but with full review/polish from me, thoug I think this one's trivial given the other one. See the other PR for example screenshot of it working. I would re-generate the compiled js files once you approve. Also, how shall we do the submodule update commit? Should I include it in this PR after the mplexplorer got in? (I find the submodule to be an annoying maintenance burden btw)
lucasb-eyer
added a commit
to lucasb-eyer/mpld3
that referenced
this pull request
Dec 1, 2025
This goes together with mpld3/mplexporter#71 it's the mpld3 side of the change. Again, done together with gpt-5.1-codex but with full review/polish from me, thoug I think this one's trivial given the other one. See the other PR for example screenshot of it working. I would re-generate the compiled js files once you approve. Also, how shall we do the submodule update commit? Should I include it in this PR after the mplexplorer got in? (I find the submodule to be an annoying maintenance burden btw)
lucasb-eyer
force-pushed
the
lb-dash-linecollections
branch
from
d8fc3eb to
f2f8898
Compare
line-style was previously ignored for line collections, this fixes it. Note that I did not add support for offset in line-style, which has not existed in the first place, and I have no need for it. There's a corresponding commit/PR in mpld3 coming. This was done together with gpt-5.1-codex (but I reviewed and edited a lot), here is what it has to say: Handle collection dasharrays in exporter - derive dash arrays from collection linestyles/dashes - carry dasharrays through export and render_path_collection so hlines/vlines/grid keep their patterns
lucasb-eyer
force-pushed
the
lb-dash-linecollections
branch
from
f2f8898 to
bda8b61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
line-style was previously ignored for line collections, this fixes it. Note that I did not add support for offset in line-style, which has not existed in the first place, and I have no need for it.
There's a corresponding commit/PR in mpld3 coming.
This was done together with gpt-5.1-codex (but I reviewed and edited a lot), here is what it has to say:
Handle collection dasharrays in exporter
And here's a bunch of hlines and vlines showing it works (including on log-axes but only with my other PRs)
