line-width was missing from gridlines.#72
Merged
vladh merged 1 commit intompld3:masterfrom Jan 2, 2026
Merged
Conversation
lucasb-eyer
added a commit
to lucasb-eyer/mpld3
that referenced
this pull request
Dec 1, 2025
For some reason, all line-styling related settings on gridlines were not set. This sets them, incuding the previously-not-exported line-width, see mpld3/mplexporter#72 As usual, disclaimer this was co-developed with gpt-5.1-codex, with my deep involvement. And as usual, I'll re-generate `make javascript` and update submodule once you approve this commit.
lucasb-eyer
added a commit
to lucasb-eyer/mpld3
that referenced
this pull request
Dec 1, 2025
For some reason, all line-styling related settings on gridlines were not set. This sets them, incuding the previously-not-exported line-width, see mpld3/mplexporter#72 As usual, disclaimer this was co-developed with gpt-5.1-codex, with my deep involvement. And as usual, I'll re-generate `make javascript` and update submodule once you approve this commit.
Member
|
LGTM! |
lucasb-eyer
added a commit
to lucasb-eyer/mpld3
that referenced
this pull request
Jan 3, 2026
For some reason, all line-styling related settings on gridlines were not set. This sets them, incuding the previously-not-exported line-width, see mpld3/mplexporter#72 As usual, disclaimer this was co-developed with gpt-5.1-codex, with my deep involvement. And as usual, I'll re-generate `make javascript` and update submodule once you approve this commit.
lucasb-eyer
added a commit
to lucasb-eyer/mpld3
that referenced
this pull request
Jan 7, 2026
For some reason, all line-styling related settings on gridlines were not set. This sets them, incuding the previously-not-exported line-width, see mpld3/mplexporter#72 As usual, disclaimer this was co-developed with gpt-5.1-codex, with my deep involvement. And as usual, I'll re-generate `make javascript` and update submodule once you approve this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple one, I was looking into grid-line styling and specification, which seems not well supported yet, and linewidth is missing from that export currently.
As usual, disclaimer that gpt-5.1-codex helped me find out, I review, polish, and test, and there's a corresponding PR in mpld3 coming.