Skip to content

add ffi tests & fix ffi#2786

Merged
mthom merged 21 commits intomthom:masterfrom
Skgland:ffi-f64-tests
Aug 10, 2025
Merged

add ffi tests & fix ffi#2786
mthom merged 21 commits intomthom:masterfrom
Skgland:ffi-f64-tests

Conversation

@Skgland
Copy link
Contributor

@Skgland Skgland commented Jan 20, 2025

Ovehauls the ffi implementation.

  • adds various tests
  • replace a lot of low level libffi usage with higher level api usage
  • adds type aliases so that rust type names for integer types can be used (float types already used f32/f64)
  • add support for cstr in return types and when unpacking structs
  • properly throw errors instead of crashing in several invalid egde cases
  • properly handle some edge cases (e.g. integers that can't fit in a fixnum)

@Skgland Skgland changed the title add ffi tests using f64 add ffi tests & fix ffi Jan 21, 2025
@Skgland

This comment was marked as outdated.

@Skgland Skgland force-pushed the ffi-f64-tests branch 5 times, most recently from f094a95 to 4d08b84 Compare January 27, 2025 19:52
@Skgland Skgland force-pushed the ffi-f64-tests branch 2 times, most recently from 6fb29af to e482f1e Compare February 17, 2025 19:05
@Skgland Skgland changed the base branch from master to rebis-dev March 27, 2025 17:46
@Skgland Skgland force-pushed the ffi-f64-tests branch 2 times, most recently from 5411849 to 45f69f0 Compare March 27, 2025 20:40
@mthom mthom force-pushed the rebis-dev branch 3 times, most recently from c2b1261 to 3549588 Compare April 12, 2025 07:22
@Skgland Skgland marked this pull request as ready for review July 5, 2025 22:15
@Skgland
Copy link
Contributor Author

Skgland commented Jul 5, 2025

I finally got this rebased and unless I forgot something I still wanted to changes this is now ready for review.

@Skgland
Copy link
Contributor Author

Skgland commented Aug 1, 2025

With CI green after the rebase this is again ready for review @mthom

@Skgland Skgland changed the base branch from rebis-dev to master August 2, 2025 09:49
@mthom mthom merged commit c0fb3fd into mthom:master Aug 10, 2025
12 checks passed
@Skgland Skgland deleted the ffi-f64-tests branch August 10, 2025 20:21
nlothian pushed a commit to nlothian/scryer-prolog that referenced this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants