Draft
Conversation
Previously, crate2nix tests were run equivalently to `cargo test --release`, which is a somewhat unusual default configuration.
Collaborator
|
Hi @edef1c! I also think it should be configurable. Usually, I execute tests locally with cargo in debug mode but then in CI in release mode. Depends quite on the test. Obviously, model tests or the like profit from release mode more than others. I haven't worked on crate2nix for a while and will first invest in flakifying it and making it work on Mac OS again (which I am using currently). But I'd be interested in hearing how such an interface could look like! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, crate2nix tests were run equivalently to
cargo test --release, which is a somewhat unusual default configuration.It might be worth having a flag to tweak this behaviour, similar to Cargo. A more ambitious version yet would permit running both debug and release versions of the tests. I'm not sure what the best interface for either of those is.