Open
Conversation
Contributor
|
#8644 is, I think, a more comprehensive approach to the failure to configure effective GUI password control. |
me-and
reviewed
Feb 8, 2026
added 2 commits
February 8, 2026 20:25
Figuring out how to structure options according to the `syncthing` API is a bit tedious. Add some sensible extra options in the provided example.
Follow the principle of "least surprise": fail at build time on misconfiguration; GUI is not password protected when setting a password using the `settings.passwordFile` option while no user is specified.
Pamplemousse
force-pushed
the
syncthing
branch
from
9429d95 to
c9e8e56
Compare
Contributor
Author
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
settingsoptions;settings.passwordFileoption while no user is specified.Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted nixf-diagnose --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.