Draft
Conversation
rycee
reviewed
Feb 15, 2026
| time = "2026-02-15T12:00:00+00:00"; | ||
| condition = true; | ||
| message = '' | ||
|
|
Member
There was a problem hiding this comment.
Why start the entry with an empty line?
rycee
reviewed
Feb 15, 2026
| lib.hm.dag.entryAfter [ "linkGeneration" ] '' | ||
| peonConfigDir="''${CLAUDE_CONFIG_DIR:-$HOME/.claude}/hooks/peon-ping" | ||
| peonConfigFile="$peonConfigDir/config.json" | ||
| if [ ! -f "$peonConfigFile" ]; then |
Member
There was a problem hiding this comment.
Suggested change
| if [ ! -f "$peonConfigFile" ]; then | |
| if [[ ! -f $peonConfigFile ]]; then |
rycee
reviewed
Feb 15, 2026
Comment on lines
+181
to
+182
| peonConfigDir="''${CLAUDE_CONFIG_DIR:-$HOME/.claude}/hooks/peon-ping" | ||
| peonConfigFile="$peonConfigDir/config.json" |
Member
There was a problem hiding this comment.
Need to unset these variables at the end of the code block
rycee
reviewed
Feb 15, 2026
Comment on lines
+184
to
+186
| run mkdir -p "$peonConfigDir" | ||
| run cp "${cfg.package}/lib/peon-ping/config.json" "$peonConfigFile" | ||
| run chmod u+w "$peonConfigFile" |
Member
There was a problem hiding this comment.
Can use the VERBOSE_ARG variable to add --verbose on verbose runs:
Suggested change
| run mkdir -p "$peonConfigDir" | |
| run cp "${cfg.package}/lib/peon-ping/config.json" "$peonConfigFile" | |
| run chmod u+w "$peonConfigFile" | |
| run mkdir $VERBOSE_ARG -p "$peonConfigDir" | |
| run cp $VERBOSE_ARG "${cfg.package}/lib/peon-ping/config.json" "$peonConfigFile" | |
| run chmod $VERBOSE_ARG u+w "$peonConfigFile" |
rycee
reviewed
Feb 15, 2026
Comment on lines
+11
to
+17
| defaultOgPacksSource = pkgs.fetchFromGitHub { | ||
| owner = "PeonPing"; | ||
| repo = "og-packs"; | ||
| rev = "v1.1.0"; | ||
| hash = "sha256-spao/GTIhH4c5HOmVc0umMvrwOaMRa4s5Pem1AWyUOw="; | ||
| }; | ||
|
|
Member
There was a problem hiding this comment.
We don't want to manage packages in Home Manager. Can either remove altogether or add it to Nixpkgs and refer to it there.
rycee
reviewed
Feb 15, 2026
| ); | ||
|
|
||
| claudeCodeHooks = lib.listToAttrs ( | ||
| map (event: lib.nameValuePair event [ (hookEntry event) ]) cfg.claudeCodeHookEvents |
Member
There was a problem hiding this comment.
The hookEntry function is only used here but defined further up. Could put it in a let binding inside this definition instead.
rycee
reviewed
Feb 15, 2026
| ( | ||
| { | ||
| type = "command"; | ||
| command = hookCommand; |
Member
There was a problem hiding this comment.
The hookCommand variable seems unnecessary, it only seems to be used here.
Member
|
Thanks for the contribution! I added some comments. |
Contributor
Author
|
Thanks a lot for the light-speed review @rycee! Will see that I get |
jonpulsifer
added a commit
to jonpulsifer/dotfiles
that referenced
this pull request
Feb 21, 2026
Vendor peon-ping v2.8.1 package and an adapted home-manager module (from nix-community/home-manager#8750) so it can be used before the upstream PRs are merged. Package (pkgs/peon-ping.nix): - Cross-platform support (macOS + Linux) — libnotify conditional on Linux - Installs adapters, scripts, and skills alongside the main peon.sh - Shell completions for bash and fish Module (home/modules/peon-ping.nix): - programs.peon-ping.enable installs package and sound packs - Copies packs as real files (not symlinks) to avoid peon's realpath path-traversal check rejecting nix store paths - Symlinks peon.sh and adapters/ into hooks dir for IDE detection - enableClaudeCodeIntegration merges hooks into settings.json - enableGeminiIntegration merges adapter hooks into ~/.gemini/settings.json - Seeds mutable default config on first activation Also fixes pre-existing syntax error in gcloud.nix (stray 'w' prefix). Co-Authored-By: Claude Opus 4.6 <[email protected]> Signed-off-by: Jonathan Pulsifer <[email protected]>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
programs.peon-pinghome-manager module for peon-ping, a notification sound player for AI coding agents (Claude Code, Cursor, Codex, etc.).Features:
programs.peon-ping.enable— installs peon-pingprograms.peon-ping.settings— declarative config (immutable nix store symlink) or mutable seeded config when left emptyprograms.peon-ping.packs— sound packs from og-packs (defaults to["peon"])programs.peon-ping.enableClaudeCodeIntegration— auto-configures Claude Code hooks and skillsDesign note — sound packs via
fetchFromGitHub:The
ogPacksSourceoption defaults to afetchFromGitHubof PeonPing/og-packs v1.1.0, which contains ~40 sound packs (~35 MB) including localized variants (German, Czech, Spanish, French, Polish, Russian). Thepacksoption selects which subdirectories to install, defaulting to["peon"].This keeps sound packs out of nixpkgs (they're audio assets, not software) while still being declaratively managed. The tradeoff is a
fetchFromGitHubat eval time pinned to a specific tag. Users can overrideogPacksSourceto point at their own source. Open to feedback on whether this approach is appropriate or if there's a preferred pattern for managing non-software assets.Dependency: This module depends on the
peon-pingpackage being available in nixpkgs. Pending PR: NixOS/nixpkgs#490742. Tests use stubs in the meantime.Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted nixf-diagnose --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module