added windows-arc-runner to Github arc setup #12
Conversation
Signed-off-by: Joseph <[email protected]>
Signed-off-by: Joseph <[email protected]>
| on: | ||
| push: | ||
| branches: [ main ] | ||
| pull_request: | ||
| branches: [ main ] | ||
| schedule: | ||
| - cron: "0 1 * * *" | ||
| workflow_dispatch: |
There was a problem hiding this comment.
These triggers are pretty frequent and overlapping.
- Is a
scheduleeven needed? How about once a week instead of daily? - Is
pull_requestneeded? We shouldn't push "latest" images on unreviewed code, but checking that the image builds successfully is useful.
| - name: Docker Push | ||
| #if: ${{ github.event_name != 'pull_request' && steps.versions.outputs.PUBLISHED != 'True' }} | ||
| run: | | ||
| docker push -a ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }} |
There was a problem hiding this comment.
Uncomment? Pull request triggers should not publish (at least without some label marking them as dev builds and not "latest" / "prod"
| build: | ||
| runs-on: windows-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
Prefer to pin runners and actions to specific versions so they don't change outside of our control
| build: | |
| runs-on: windows-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| build: | |
| runs-on: windows-2022 | |
| steps: | |
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 |
There was a problem hiding this comment.
I remember seeing warnings about changes to Windows runners over the past few months on GitHub. I see the job on this PR failed due to lack of disk space. This could be related. I'll try to dig up info after I finish eating.
There was a problem hiding this comment.
Yep. Looks like they swapped from 2022 to 2025, and the job was last run months ago. Probably is a good idea to be fixed to the 2022 runner.
There was a problem hiding this comment.
windows-2025 is also fine with me (if it works)
There was a problem hiding this comment.
I am assuming windows-latest (i.e., 2022) did not run into the disk space error the last time Elias ran this workflow. I see others complaining about disk space with 2025 runners: actions/runner-images#12609
There was a problem hiding this comment.
yeah, I didn't see the disc space errors before
| # Define the entry point for the docker container. | ||
| # This entry point starts the developer command prompt and launches the PowerShell shell. | ||
| RUN choco install cmake --version=3.31.0 -y --no-progress --installargs '"ADD_CMAKE_TO_PATH=System"' | ||
| RUN choco install python -y --no-progress |
There was a problem hiding this comment.
We may want to pin the Python version here so it doesn't update when the dockerfile is rebuilt
Initial pull request. I'm looking at trimming down comments