Bump IREE requirement pins to 3.11.0rc20260304#2848
Merged
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ange
This commit updates shortfin to work with IREE PR #23576 (commit eacda0d,
Feb 25, 2026), which introduced iree_hal_device_group_t to own device
topology lifecycle.
Background:
-----------
IREE PR #23576 refactored the HAL module API to fix a lifetime ownership
problem. Previously, devices received raw pointers to topology data with
no guarantees that those pointers remained valid. The new device_group
abstraction owns the device lifecycle and ensures topology pointer
validity.
API Changes:
------------
The iree_hal_module_create() signature changed from 8 to 7 parameters:
Before:
iree_hal_module_create(instance, policy, device_count, devices[],
flags, debug_sink, allocator, out_module)
After:
iree_hal_module_create(instance, policy, device_group,
flags, debug_sink, allocator, out_module)
Implementation:
---------------
1. Added hal_device_group_ptr smart pointer wrapper in iree_helpers.h
using the SHORTFIN_IREE_DEF_PTR macro
2. Updated program.cc to create device groups before module creation:
- Single device: Uses iree_hal_device_group_create_from_device()
- Multiple devices: Uses builder pattern with
iree_hal_device_group_builder_* APIs
Benefits:
---------
- Clear lifetime semantics (module retains group; group retains devices)
- Topology safety (pointers guaranteed valid for device lifetime)
- Simplified allocation (no flexible array members)
References:
-----------
- IREE PR: iree-org/iree#23576
- Commit: eacda0d84b0a357d5ea701fec9137346fc724f59
Co-Authored-By: Claude Opus 4.6 <[email protected]>
The --iree-llvmgpu-enable-prefetch flag has been removed in the latest IREE version and is no longer supported by iree-compile. This flag was causing compilation failures with error: "Unknown command line argument '--iree-llvmgpu-enable-prefetch=1'" Changes: -------- - Removed --iree-llvmgpu-enable-prefetch from vae_test.py (2 occurrences) - Removed --iree-llvmgpu-enable-prefetch from flux/compile.py This is part of the IREE version bump to 3.11.0rc20260304 which removed several deprecated compiler flags. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
Coverage report
This PR does not seem to contain any modification to coverable code. |
pravg-amd
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff: iree-org/iree@iree-3.11.0rc20260224...iree-3.11.0rc20260304
IREE bump duty engineer this week: @
Auto-generated by GitHub Actions using
.github/workflows/update_iree_requirement_pins.yml.