[KernelDispatch] Add a temporary hack for 1x1 shapes with tile sizes M,N #1276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhishek-Varma
requested review from
MaheshRavishankar,
yzhang93,
jtuyls,
newling and
Yu-Zhewen
as code owners
yzhang93
requested changes
May 23, 2025
...r/plugins/target/AMD-AIE/iree-amd-aie/Transforms/test/lowering_strategy_objectfifo_npu4.mlir
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/KernelDispatch.cpp
Outdated
Show resolved
Hide resolved
...r/plugins/target/AMD-AIE/iree-amd-aie/Transforms/test/lowering_strategy_objectfifo_npu4.mlir
Show resolved
Hide resolved
...r/plugins/target/AMD-AIE/iree-amd-aie/Transforms/test/lowering_strategy_objectfifo_npu4.mlir
Outdated
Show resolved
Hide resolved
Comment on lines
453
to
455
| // TODO(avarma): This is currently a workaround for 1x1 AIE array to make | ||
| // those 2D matmul shapes work for which all of the operands get pulled in | ||
| // to L2 buffer. Once reprogramming of DMA ops is supported, we can get rid |
There was a problem hiding this comment.
I didn't follow what's the problem here. What's the error message?
There was a problem hiding this comment.
Without this we get 'aie.memtile_dma' op could not find and assign a valid BD id - because of exploding memtile_dma issue, which should be solved by having DMA ops reconfigured. But since the support is not yet available, this is a temporary workaround.
Abhishek-Varma
force-pushed
the
avarma_hack_32x512x64_1x1
branch
from
9a9672a to
7aa28d1
Compare
-- This commit adds a temporary hack for 1x1 AIE array to make those 2D matmul shapes work for which all of the operands get pulled in to L2 buffer. Once reprogramming of DMA ops is supported, we can get rid of this workaround. We need to add this only for pack-peel-4-level-tiling NOT pack-peel. The workaround just ensures that the tile size of first level is NOT equal to M,N by halving the n0Tile. -- Also adds e2e 32x512x64 for 1x1 npu4 test. Signed-off-by: Abhishek Varma <[email protected]>
Abhishek-Varma
force-pushed
the
avarma_hack_32x512x64_1x1
branch
from
7aa28d1 to
2d0a1de
Compare
jtuyls
reviewed
May 26, 2025
| // of this workaround. We need to add this only for pack-peel-4-level-tiling | ||
| // NOT pack-peel. The workaround just ensures that the tile size of first | ||
| // level is NOT equal to M, N by halving the N0 tile. | ||
| if (numRows == 1 && numCols == 1) { |
There was a problem hiding this comment.
Do you only see this issue for 1x1? I would expect it for any number of cores?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- This commit adds a temporary hack for 1x1 AIE array to make those
2D matmul shapes work for which all of the operands get pulled in to L2
buffer. Once reprogramming of DMA ops is supported, we can get rid of this
workaround. We need to add this only for pack-peel-4-level-tiling NOT
pack-peel. The workaround just ensures that the tile size of first level is
NOT equal to M,N by halving the n0Tile and halving the corresponding packing
size in case n0Tile becomes lesser than the packing size.
-- Also adds e2e 32x512x64 for 1x1 npu4 test.
Signed-off-by: Abhishek Varma [email protected]