[Reduction] Verify different sizes and types work for reduction. #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch adds tests to make sure all the tests with `vector.multi_reduction` generate successfully pass Peano legalizer and generate efficient vectorized code. This patch checks only the IREE side to keep the dependency minimun on Peano. (Depends on Peano: 1. Xilinx/llvm-aie#548 2. Xilinx/llvm-aie#557 ) 1. `reassociateFpReductions=true` is must else code is scalarized. This flag could be added into the IREE vectorization pipeline to trigger automatically. 2. bf16/i32/f32 all types with different sizes work now.
Sameeranjoshi
requested review from
MaheshRavishankar,
yzhang93,
Abhishek-Varma,
jtuyls,
newling and
Yu-Zhewen
as code owners
|
Summary: 1D/2D – Powers of 2
|
Sameeranjoshi
added a commit
to Sameeranjoshi/llvm-aie
that referenced
this pull request
Jul 22, 2025
…d code. This patch is dependent on Xilinx#548 and Xilinx#557. Previously bf16 and f32 failed to generate fully vectorized code and used to scalarize, this test makes sures different types and vector sizes work and are fully vectorized. This is a supplementary patch for verifying below pipeline: Part 1: `vector.multi_reduction` to `vector.reduction` to `llvm.vector.reduce.fadd.*` nod-ai/iree-amd-aie#1336 Part 2: Further lowers to AIE2P instructions.(This patch)
newling
reviewed
Jul 22, 2025
There was a problem hiding this comment.
These tests are nice, but I think we should see what our compiler flow is once we've done the unrolling of transfer_reads.
Ideally we'd be able to have FileCheck commands for the generated assembly, to verify that the legalization changes are working as expected too. But that'd presumably add a dependency on peano which we don't want in our lit testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch adds tests to make sure all the tests with
vector.multi_reductiongenerate successfully pass Peano legalizer and generate efficient vectorized code. This patch checks only the IREE side to keep the dependency minimun on Peano. (Depends on Peano:Legalizer support for vectors in G_FPEXT Xilinx/llvm-aie#548
Handle Vector types in G_FADD using G_FPEXT Xilinx/llvm-aie#557 )
reassociateFpReductions=trueis must else code is scalarized. This flag could be added into the IREE vectorization pipeline to trigger automatically.bf16/i32/f32 all types with different sizes work now.