Iree multi reduction support #1346
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enerates vector.extract + vector.add + vector.insert, need vector.transfer_Write instead.
This is partial fix, the program fails for out of Program memory on a core. 1. solves the reduction legalizer issue. 2. Converts the transfer_reads into loads 3. Applies 2D->1D flattening pattern on vector type. 4. Solves stack size problem by bumping the stack size.
1. Selected appropriate tile sizes. Peano vectorizes for <32xbf16> we choose the tile sizes such that we always generate the legal shapes. 2. found the bounds for both bf16 and f32 which work. 3. Tested the patch and cleaned up the patterns.
F32 Correctness: Pass Benchmark: Fails PM issue(run_benchmarks=true) BF16: Correctness: Fails Benchmarks: Pass(but this might be not correct as results are wrong) Run commands: python run.py delete_out_reduction $IREE_DIR --xrt_dir=$XRT_DIR --peano_dir=$PEANO_DIR \ --target_device="npu4" --xrt_lite_n_core_rows=$XRT_LITE_N_CORE_ROWS \ --xrt_lite_n_core_cols=$XRT_LITE_N_CORE_COLS --tests Reduction
Sameeranjoshi
requested review from
MaheshRavishankar,
yzhang93,
Abhishek-Varma,
jtuyls,
newling and
Yu-Zhewen
as code owners
|
Nice! FFR, accompanying peano changes: Xilinx/llvm-aie#604 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single commit fix for #1306
vector.multi_reduction -> vector.reductionandtransfer_read/writes -> load/storesReductiontests inrun.py